Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More comprehensive/robust conversion of docstring type/rtype to type … #2401

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Apr 16, 2024

…annotations

Should cover everything currently present in amici.py, except for overloaded methods.

Exclude two methods from swig interface that aren't easily usable from Python.

…annotations

Should cover everything currently present in amici.py, except for overloaded methods.
@dweindl dweindl requested a review from a team as a code owner April 16, 2024 20:45
@dweindl dweindl self-assigned this Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 15.62500% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 75.92%. Comparing base (6bbcde2) to head (de8a635).

❗ Current head de8a635 differs from pull request most recent head db700e5. Consider uploading reports for the commit db700e5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2401      +/-   ##
===========================================
- Coverage    78.29%   75.92%   -2.38%     
===========================================
  Files          324      324              
  Lines        20875    20894      +19     
  Branches      1458     1450       -8     
===========================================
- Hits         16345    15864     -481     
- Misses        4527     5027     +500     
  Partials         3        3              
Flag Coverage Δ
cpp 73.39% <15.62%> (-0.68%) ⬇️
cpp_python ?
petab 36.78% <15.62%> (-0.04%) ⬇️
python 69.82% <15.62%> (-3.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/sdist/amici/swig.py 12.50% <15.62%> (+1.97%) ⬆️

... and 15 files with indirect coverage changes

@dweindl dweindl merged commit 0bba236 into AMICI-dev:develop Apr 19, 2024
15 of 18 checks passed
@dweindl dweindl deleted the typehintfixer branch April 19, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants