Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally include measurements in plot_observable_trajectories #2381

Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 13, 2024

If some ExpData is provided, plot_observable_trajectories will now also visualize the measurements.

Example:
image

If some `ExpData` is provided, `plot_observable_trajectories` will now also visualize the measurements.
@dweindl dweindl requested a review from a team as a code owner March 13, 2024 16:11
@dweindl dweindl changed the base branch from master to develop March 13, 2024 16:12
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 77.87%. Comparing base (4d40911) to head (1d98fb4).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2381      +/-   ##
===========================================
+ Coverage    77.73%   77.87%   +0.13%     
===========================================
  Files          324      324              
  Lines        20864    20869       +5     
  Branches      1458     1458              
===========================================
+ Hits         16219    16251      +32     
+ Misses        4642     4615      -27     
  Partials         3        3              
Flag Coverage Δ
cpp 76.27% <0.00%> (+2.75%) ⬆️
cpp_python 34.22% <0.00%> (-0.01%) ⬇️
petab 36.81% <0.00%> (-0.02%) ⬇️
python 72.42% <0.00%> (+0.13%) ⬆️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/sdist/amici/plotting.py 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

@dweindl dweindl merged commit 41b4ce4 into AMICI-dev:develop Mar 13, 2024
27 of 28 checks passed
@dweindl dweindl deleted the feature_plot_observables_with_data branch March 13, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants