Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type annotations in swig-wrappers (again) #2365

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 7, 2024

Some things were missing in #2344

@dweindl dweindl requested a review from a team as a code owner March 7, 2024 13:16
@dweindl dweindl self-assigned this Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 77.66%. Comparing base (8d65524) to head (1388009).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2365      +/-   ##
===========================================
- Coverage    77.66%   77.66%   -0.01%     
===========================================
  Files          324      324              
  Lines        20825    20824       -1     
  Branches      1454     1454              
===========================================
- Hits         16174    16173       -1     
  Misses        4648     4648              
  Partials         3        3              
Flag Coverage Δ
cpp 73.43% <0.00%> (-0.01%) ⬇️
cpp_python 34.25% <0.00%> (-0.01%) ⬇️
petab 36.86% <0.00%> (-0.01%) ⬇️
python 72.22% <0.00%> (-0.01%) ⬇️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/sdist/amici/swig.py 10.52% <0.00%> (ø)

... and 1 file with indirect coverage changes

@dweindl dweindl merged commit 6f12f85 into AMICI-dev:develop Mar 7, 2024
18 of 20 checks passed
@dweindl dweindl deleted the fix_swig_typeannot branch March 7, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants