Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with paths containing blanks for sundials #2361

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 6, 2024

...

@dweindl dweindl requested a review from a team as a code owner March 6, 2024 19:17
@dweindl dweindl self-assigned this Mar 6, 2024
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.24%. Comparing base (19f7baf) to head (ac7716d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2361      +/-   ##
===========================================
- Coverage    77.63%   76.24%   -1.39%     
===========================================
  Files          324      319       -5     
  Lines        20769    20614     -155     
  Branches      1449     1449              
===========================================
- Hits         16124    15718     -406     
- Misses        4642     4892     +250     
- Partials         3        4       +1     
Flag Coverage Δ
cpp 73.43% <ø> (ø)
cpp_python 34.26% <ø> (ø)
petab ?
python 72.23% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

@dweindl dweindl merged commit dcc81d1 into AMICI-dev:develop Mar 6, 2024
17 of 20 checks passed
@dweindl dweindl deleted the blanks branch March 6, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants