Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't eliminate parameters that are initial assignment targets (pt2) #2305

Merged
merged 5 commits into from
Feb 27, 2024

Commits on Feb 23, 2024

  1. Don't eliminate parameters that are initial assignment targets (pt2)

    Currently, parameters that are targets of initial assignments don't show up as parameters or expressions in the amici model. This is rather not what most users would expect.
    
    Therefore, treat all SBML parameters that are initial assignment targets and whose initial assignment does not evaluate to a number (for those that do, see AMICI-dev#2304) as amici expressions.
    Those static expressions will be handled more efficiently after AMICI-dev#2303.
    
    Related to AMICI-dev#2150.
    dweindl committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    3e1f906 View commit details
    Browse the repository at this point in the history
  2. ..

    dweindl committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    249fbc0 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. Configuration menu
    Copy the full SHA
    5fae510 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Configuration menu
    Copy the full SHA
    dcb6b70 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    504d447 View commit details
    Browse the repository at this point in the history