Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: t0 #2263

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Doc: t0 #2263

merged 1 commit into from
Jan 8, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 8, 2024

Closes #2248

@dweindl dweindl linked an issue Jan 8, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d01ebb) 77.07% compared to head (e5c8a27) 76.88%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2263      +/-   ##
===========================================
- Coverage    77.07%   76.88%   -0.19%     
===========================================
  Files           92       92              
  Lines        14980    14980              
===========================================
- Hits         11546    11518      -28     
- Misses        3434     3462      +28     
Flag Coverage Δ
cpp 74.08% <ø> (+0.02%) ⬆️
cpp_python ?
petab 52.90% <ø> (ø)
python 77.94% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
include/amici/model.h 61.11% <ø> (ø)
include/amici/simulation_parameters.h 66.66% <ø> (ø)

... and 6 files with indirect coverage changes

@dweindl dweindl marked this pull request as ready for review January 8, 2024 09:21
@dweindl dweindl requested a review from a team as a code owner January 8, 2024 09:21
@dweindl dweindl self-assigned this Jan 8, 2024
@dweindl dweindl merged commit 8077915 into AMICI-dev:develop Jan 8, 2024
19 of 20 checks passed
@dweindl dweindl deleted the doc_2248 branch January 17, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timepoints in Model and ExpData relative to T0 or not?
2 participants