Fix CMake using incorrect Python library for building model extension #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where a model extension would be built for an incorrect
Python version. If there is a newer Python version available than the one
in use during model import, CMake would incorrectly used the newer version.
This results in not so informative errors like:
```
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/model_name/model_name.py", line 12, in <module>
import _model_name
ModuleNotFoundError: No module named '_model_name'
```
Fixed here by explicitly setting the Python executable that is used to
find the matching libraries.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2220 +/- ##
========================================
Coverage 76.50% 76.50%
========================================
Files 91 91
Lines 15034 15034
========================================
Hits 11502 11502
Misses 3532 3532
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where a model extension would be built for an incorrect Python version. If there is a newer Python version available than the one in use during model import, CMake would incorrectly used the newer version. This results in not so informative errors like:
Fixed here by explicitly setting the Python executable that is used to find the matching libraries.