Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake set CMP0144 #2209

Merged
merged 1 commit into from
Nov 21, 2023
Merged

CMake set CMP0144 #2209

merged 1 commit into from
Nov 21, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 20, 2023

Fixes #2208

@dweindl dweindl marked this pull request as ready for review November 20, 2023 14:16
@dweindl dweindl requested a review from a team as a code owner November 20, 2023 14:16
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #2209 (8e98624) into develop (3330ccb) will decrease coverage by 22.89%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2209       +/-   ##
============================================
- Coverage    76.68%   53.80%   -22.89%     
============================================
  Files           82       34       -48     
  Lines        15012     5652     -9360     
============================================
- Hits         11512     3041     -8471     
+ Misses        3500     2611      -889
Flag Coverage Δ
cpp ?
petab 53.80% <ø> (ø)
python ?
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 66 files with indirect coverage changes

@dweindl dweindl linked an issue Nov 20, 2023 that may be closed by this pull request
Policy CMP0144 is not set #2208
Closed
@dweindl dweindl merged commit 892a7c8 into AMICI-dev:develop Nov 21, 2023
9 of 10 checks passed
@dweindl dweindl deleted the fix_CMP0144 branch November 21, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFroehlich FFroehlich FFroehlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Policy CMP0144 is not set
2 participants
@dweindl @FFroehlich