Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer __repr__ for ReturnDataView #2192

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Nicer __repr__ for ReturnDataView #2192

merged 1 commit into from
Nov 15, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 15, 2023

Previously:

<ReturnDataView(<amici.amici.ReturnData; proxy of <Swig Object of type 'amici::ReturnData *' at 0x7f794a9ef8d0> >)>

Now:

<ReturnDataView(id='ctrl+basal_preeq', status=AMICI_SUCCESS)>

Previously:

```
<ReturnDataView(<amici.amici.ReturnData; proxy of <Swig Object of type 'amici::ReturnData *' at 0x7f794a9ef8d0> >)>
```

Now

```
<ReturnDataView(id='ctrl+basal_preeq', status=AMICI_SUCCESS)>
```
@dweindl dweindl requested a review from a team as a code owner November 15, 2023 09:09
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #2192 (7435163) into develop (269910b) will decrease coverage by 0.85%.
Report is 1 commits behind head on develop.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2192      +/-   ##
===========================================
- Coverage    77.45%   76.60%   -0.85%     
===========================================
  Files           82       82              
  Lines        15004    15007       +3     
===========================================
- Hits         11621    11496     -125     
- Misses        3383     3511     +128     
Flag Coverage Δ
cpp 73.53% <ø> (ø)
petab 53.83% <33.33%> (-0.02%) ⬇️
python 77.14% <33.33%> (-2.31%) ⬇️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/sdist/amici/numpy.py 81.37% <33.33%> (-1.46%) ⬇️

... and 1 file with indirect coverage changes

@dweindl dweindl merged commit eccdc1f into develop Nov 15, 2023
16 of 19 checks passed
@dweindl dweindl deleted the rdataview_repr branch November 15, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants