Fix misleading preequilibration failure messages #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When preequilibration (or finding a steadystate in general) fails, `SteadystateProblem::handleSteadyStateFailure` produced `AMICI simulation failed: Steady state computation failed. First run of Newton solver failed. Simulation to steady state failed: No convergence was achieved. Second run of Newton solver failed.`, even in cases where no Newton solve or no simulation was attempted. This is confusing and is changed here, so that the message now reflects what has actually happened. Closes #2178
dweindl
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #2181 +/- ##
========================================
Coverage 53.93% 53.93%
========================================
Files 34 34
Lines 5625 5625
========================================
Hits 3034 3034
Misses 2591 2591
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When preequilibration (or finding a steadystate in general) fails,
SteadystateProblem::handleSteadyStateFailureproducedAMICI simulation failed: Steady state computation failed. First run of Newton solver failed. Simulation to steady state failed: No convergence was achieved. Second run of Newton solver failed., even in cases where no Newton solve or no simulation was attempted. This is confusing and is changed here, so that the message now reflects what has actually happened.Closes #2178