Fix SBML import for events with trigger functions depending on parame… #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters that are initial assignment targets
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2145 +/- ##
===========================================
- Coverage 76.61% 76.56% -0.05%
===========================================
Files 81 82 +1
Lines 14926 14943 +17
===========================================
+ Hits 11435 11441 +6
- Misses 3491 3502 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SBML import for events with trigger functions depending on parameters that are initial assignment targets.
I.e. given the current way of processing initial assignments, events have to be processed first. Otherwise model compilation fails with
use of undeclared identifier, because the respective parameter was replaced by its initial assignment value.Credits to @LeaSeep for triggering that issue.