Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model import: Don't create spl.h and sspl.h for models without splines #2088

Merged
merged 1 commit into from
May 16, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented May 16, 2023

Closes #2087

@dweindl dweindl requested a review from a team as a code owner May 16, 2023 07:26
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #2088 (4156d63) into develop (c3595c4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2088   +/-   ##
========================================
  Coverage    76.10%   76.11%           
========================================
  Files           80       80           
  Lines        14838    14840    +2     
========================================
+ Hits         11293    11296    +3     
+ Misses        3545     3544    -1     
Flag Coverage Δ
cpp 73.56% <ø> (+0.01%) ⬆️
petab 49.46% <100.00%> (+0.01%) ⬆️
python 76.87% <100.00%> (+<0.01%) ⬆️
sbmlsuite ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/sdist/amici/de_export.py 91.60% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl added this pull request to the merge queue May 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2023
@dweindl dweindl added this pull request to the merge queue May 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2023
@dweindl dweindl merged commit 8868dc1 into develop May 16, 2023
@dweindl dweindl deleted the fix_2087 branch May 16, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants