Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to detect conservation laws for models with Species-AssignmentRules #2056

Merged
merged 4 commits into from
Apr 25, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Apr 24, 2023

No description provided.

@dweindl dweindl requested a review from a team as a code owner April 24, 2023 09:38
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #2056 (50decbd) into develop (0974d89) will increase coverage by 0.04%.
The diff coverage is 70.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2056      +/-   ##
===========================================
+ Coverage    75.22%   75.27%   +0.04%     
===========================================
  Files           75       75              
  Lines        13011    13017       +6     
===========================================
+ Hits          9788     9798      +10     
+ Misses        3223     3219       -4     
Flag Coverage Δ
cpp 72.85% <ø> (+0.05%) ⬆️
petab 53.79% <70.00%> (+0.03%) ⬆️
python 69.64% <70.00%> (+0.01%) ⬆️
sbmlsuite ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/sdist/amici/sbml_import.py 76.77% <70.00%> (+0.05%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Is this about detection of conservation laws or about the actual computation?

python/sdist/amici/sbml_import.py Outdated Show resolved Hide resolved
python/sdist/amici/sbml_import.py Outdated Show resolved Hide resolved
Co-authored-by: Fabian Fröhlich <fabian_froehlich@hms.harvard.edu>
@dweindl
Copy link
Member Author

dweindl commented Apr 24, 2023

Is this about detection of conservation laws or about the actual computation?

The computation for the detection.

@dweindl dweindl changed the title Don't try to compute conservation laws for models with Species-AssignmentRules Don't try to detect conservation laws for models with Species-AssignmentRules Apr 24, 2023
@dweindl dweindl merged commit b47ea26 into develop Apr 25, 2023
@dweindl dweindl deleted the fix_cls_spec_assgnmt branch April 25, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants