Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix varying cmake libdir lib(64)/ #2033

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Fix varying cmake libdir lib(64)/ #2033

merged 1 commit into from
Mar 8, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 8, 2023

Some systems use lib/, some lib64/.

Just adding the amici package base dir to CMAKE_PREFIX_PATH doesn't suffice to find FindSuiteSparse_config.cmake.

@dweindl dweindl requested a review from a team as a code owner March 8, 2023 06:57
@dweindl dweindl self-assigned this Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #2033 (ecd6bbb) into develop (ecd6bbb) will not change coverage.
The diff coverage is n/a.

❗ Current head ecd6bbb differs from pull request most recent head 140f692. Consider uploading reports for the commit 140f692 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2033   +/-   ##
========================================
  Coverage    71.74%   71.74%           
========================================
  Files           72       72           
  Lines        12921    12921           
========================================
  Hits          9270     9270           
  Misses        3651     3651           
Flag Coverage Δ
cpp 72.85% <0.00%> (ø)
python 69.62% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dweindl dweindl merged commit 0996b6a into develop Mar 8, 2023
@dweindl dweindl deleted the fix_libdir branch March 8, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants