Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify OpenBLAS installation on Windows #2016

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Simplify OpenBLAS installation on Windows #2016

merged 1 commit into from
Feb 23, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 23, 2023

  • Use cmake-install instead of funny manual copying
  • Build parallel
  • Upload build artifacts for debugging
  • Silence stupid MSVC copyright messages

@dweindl
Simplify OpenBLAS installation on Windows
9324813 
* Use cmake-install instead of funny manual copying
* Build parallel
* Upload build artifacts for debugging
* Silence stupid MSVC copyright messages
@dweindl dweindl requested a review from a team as a code owner February 23, 2023 14:21
@codecov
Copy link

codecov bot commented Feb 23, 2023 •
edited
Loading

Codecov Report

Merging #2016 (9324813) into develop (cfe49a1) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2016      +/-   ##
===========================================
+ Coverage    76.16%   76.18%   +0.02%     
===========================================
  Files           76       76              
  Lines        13004    13004              
===========================================
+ Hits          9904     9907       +3     
+ Misses        3100     3097       -3
Flag Coverage Δ
cpp 73.40% <ø> (+0.03%) ⬆️
petab 60.03% <ø> (ø)
python 68.85% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/solver_cvodes.cpp 70.39% <0.00%> (+0.16%) ⬆️
src/exception.cpp 80.00% <0.00%> (+5.71%) ⬆️

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

FFroehlich
FFroehlich approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 2aef279 into develop Feb 23, 2023
@dweindl dweindl deleted the simplify_openblas branch February 23, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFroehlich FFroehlich FFroehlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dweindl @FFroehlich