Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: raise minimum required version to 3.15 #2002

Merged
merged 5 commits into from
Feb 20, 2023
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 20, 2023

Seems fair to require a CMake version not older than 3 years+

Simplifies CMake files, and some newer features will be required for #1992.

Seems fair to require a CMake version not older than 3 years+

Simplifies CMake files, and some newer features will be required for #1992.
@dweindl dweindl requested a review from a team as a code owner February 20, 2023 10:21
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #2002 (dcc114f) into develop (efa1531) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2002   +/-   ##
========================================
  Coverage    76.06%   76.06%           
========================================
  Files           76       76           
  Lines        12993    12993           
========================================
  Hits          9883     9883           
  Misses        3110     3110           
Flag Coverage Δ
cpp 73.20% <ø> (ø)
petab 60.03% <ø> (ø)
python 68.86% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl merged commit 0742d64 into develop Feb 20, 2023
@dweindl dweindl deleted the cmake_version branch February 20, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants