Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass model_name to _create_model_output_dir_name #1994

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Conversation

FFroehlich
Copy link
Member

fixes #1993

@FFroehlich FFroehlich requested a review from a team as a code owner February 16, 2023 08:37
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1994 (7ff7142) into develop (f7b2f7b) will increase coverage by 0.02%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1994      +/-   ##
===========================================
+ Coverage    76.00%   76.03%   +0.02%     
===========================================
  Files           76       76              
  Lines        13003    13005       +2     
===========================================
+ Hits          9883     9888       +5     
+ Misses        3120     3117       -3     
Flag Coverage Δ
cpp 73.15% <ø> (+0.05%) ⬆️
petab 60.03% <50.00%> (-0.03%) ⬇️
python 68.86% <0.00%> (-0.04%) ⬇️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/sdist/amici/petab_import.py 65.49% <50.00%> (-0.52%) ⬇️
src/solver_cvodes.cpp 70.23% <0.00%> (+0.16%) ⬆️
src/sundials_matrix_wrapper.cpp 80.61% <0.00%> (+0.40%) ⬆️
src/exception.cpp 80.00% <0.00%> (+5.71%) ⬆️

@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@FFroehlich FFroehlich merged commit b4ae6aa into develop Feb 16, 2023
@FFroehlich FFroehlich deleted the fix_1993 branch February 16, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

passing model_name in import_petab_problem doesn't affect name of generated model dir
2 participants