fix equilibraton status discrepancy #1991
Conversation
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1991 +/- ##
===========================================
- Coverage 76.06% 76.02% -0.05%
===========================================
Files 76 76
Lines 13002 13003 +1
===========================================
- Hits 9890 9885 -5
- Misses 3112 3118 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| forward sensitivities ODEs is coupled. If 'integrationOnly' approach is | ||
| chosen for sensitivity computation it is enforced that steady state is | ||
| computed only by numerical integration as well. */ | ||
| bool turnOffNewton = solver.getNewtonMaxSteps() == 0 || ( |
There was a problem hiding this comment.
why do we need ((it == -1 && solver.getSensitivityMethodPreequilibration() == SensitivityMethod::forward) || solver.getSensitivityMethod() == SensitivityMethod::forward)) anyways?
There was a problem hiding this comment.
The latter is necessary as numerical integration of the model ODEs and corresponding forward sensitivities ODEs is coupled. If 'integrationOnly' approach is chosen for sensitivity computation it is enforced that steady state is computed only be numerical integration as well.
There was a problem hiding this comment.
It turns off Newton's method if SteadyStateSensitivityMode::integrationOnly is set together with SensitivityMethod::forward
|
Kudos, SonarCloud Quality Gate passed! |
Turn off Newton's method if newton_maxsteps is set to 0, so that in that case the resulting status will be
[0 1 0]([Did not run; Successful run; Did not run]) if numerical integration was successful. Before the status was[-2 1 0]([Error: The method did not converge to a steady state within the maximum number of steps (Newton's method or simulation). ; Successful run; Did not run]).Overall Newton's method is turned off if newton_maxsteps is set to 0 or if 'integrationOnly' approach is chosen for sensitivity computation in combination with forward sensitivities approach. The latter is necessary as numerical integration of the model ODEs and corresponding forward sensitivities ODEs is coupled. If 'integrationOnly' approach is chosen for sensitivity computation it is enforced that steady state is computed only be numerical integration as well.