Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warning (matlab) #1954

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Fix compiler warning (matlab) #1954

merged 1 commit into from
Jan 24, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 24, 2023

Fixes warning: comparison of integer expressions of different signedness

Fixes `warning: comparison of integer expressions of different signedness`
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #1954 (c53dda4) into develop (c25c666) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1954      +/-   ##
===========================================
+ Coverage    75.96%   75.99%   +0.02%     
===========================================
  Files           76       76              
  Lines        12979    12979              
===========================================
+ Hits          9860     9863       +3     
+ Misses        3119     3116       -3     
Flag Coverage Δ
cpp 73.16% <ø> (+0.03%) ⬆️
petab 59.68% <ø> (ø)
python 68.95% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/solver_cvodes.cpp 70.23% <0.00%> (+0.16%) ⬆️
src/exception.cpp 80.00% <0.00%> (+5.71%) ⬆️

@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dweindl dweindl merged commit f12f830 into develop Jan 24, 2023
@dweindl dweindl deleted the fix_matlabwarn branch January 24, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants