Improve logging #1907
Merged
Improve logging #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1907 +/- ##
===========================================
+ Coverage 75.76% 75.92% +0.15%
===========================================
Files 75 76 +1
Lines 12913 12928 +15
===========================================
+ Hits 9784 9815 +31
+ Misses 3129 3113 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Dec 9, 2022
Co-authored-by: Fabian Fröhlich <fabian@schaluck.com>
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier for users to filter log messages.
breaking changes:
For Python:
Don't print messages to stdout, but collect them in
ReturnDataand forward them to python logging, making it easier to filter specific messages or to disable output completely.For C++:
Don't print messages to stdout, but collect them in
ReturnData, and let the user decide what to do with it.This implies, that messages will no longer be shown as they occur, but only after
runAmiciSimulationfinishes. Downside: no live output. Upside: We can prefix messages with simulation condition IDs, making it easier to see which where any errors occurred. This is particularly helpful forrunAmiciSimulationwith multiple conditions.Also resolves #1550.
Note: This should also allow us to stop using
wurlitzerand should resolve any weird output redirection issues that occurred previously. To be done separately.