Extract common subexpressions #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option to extract common subexpressions during code generation (at the model function level, not added to `w`). Disabled by default, can be enabled via environment variable `AMICI_EXTRACT_CSE=1`. For large models, this may significantly reduce file size and speed up compilation. Downside: The resulting files are hard to read / debug. With my test model (SBML import, 2 processes, sequential compilation with clang14, -O2): | | before | after | |-----------------|----------------|----------------| | import time | 160 min (100%) | 164 min (103%) | | code size | 89 MB (100%) | 27 MB (30%) | | compile time | 169 min (100%) | 90 min (53%) | | compile RAM | 7.49 GB (100%) | 1.18 GB (16%) |
Codecov Report
@@ Coverage Diff @@
## develop #1852 +/- ##
===========================================
+ Coverage 76.27% 76.68% +0.41%
===========================================
Files 74 74
Lines 12851 13551 +700
===========================================
+ Hits 9802 10392 +590
- Misses 3049 3159 +110
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Aug 22, 2022
Oh, and maybe add a test that runs cse on a nontrivial testcase? |
|
SonarCloud Quality Gate failed. |
dweindl
added a commit
that referenced
this pull request
Aug 23, 2022
Benchmarking in #1852 was done with `cse(..., ignore=None)`. Turns out, passing symbols to ignore makes things 1000x slower. Here we toposort the original and extracted expressions together, instead of ignoring any dependent-symbols.
dweindl
added a commit
that referenced
this pull request
Aug 23, 2022
Benchmarking in #1852 was done with `cse(..., ignore=None)`. Turns out, passing symbols to ignore makes things 1000x slower. Here we toposort the original and extracted expressions together, instead of ignoring any dependent symbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to extract common subexpressions during code generation (at the model function level, not added to
w).Disabled by default, can be enabled via environment variable
AMICI_EXTRACT_CSE=1.For large models, this may significantly reduce file size and speed up compilation.
Downside: The resulting files are hard to read / debug.
With my test model (SBML import, 2 processes, sequential compilation with clang14, -O2):
(*) lowest out of 20 identical simulations using ASA