Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Observables #1845

Merged
merged 18 commits into from
Aug 6, 2022
Merged

Event Observables #1845

merged 18 commits into from
Aug 6, 2022

Conversation

FFroehlich
Copy link
Member

also includes some fixes to the way the computation of deltasx is implemented (uses symbols for stau instead of using equations).

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1845 (f3c1fc6) into develop (1f5e5ef) will increase coverage by 0.30%.
The diff coverage is 95.87%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1845      +/-   ##
===========================================
+ Coverage    76.07%   76.37%   +0.30%     
===========================================
  Files           74       74              
  Lines        12685    12834     +149     
===========================================
+ Hits          9650     9802     +152     
+ Misses        3035     3032       -3     
Flag Coverage Δ
cpp 72.85% <90.24%> (+0.16%) ⬆️
petab 59.40% <62.09%> (+0.02%) ⬆️
python 69.17% <97.38%> (+0.80%) ⬆️
sbmlsuite 87.14% <68.85%> (-1.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/amici/model.h 56.00% <ø> (ø)
python/amici/gradient_check.py 83.15% <0.00%> (-2.72%) ⬇️
python/amici/pysb_import.py 94.61% <ø> (ø)
src/model.cpp 77.55% <88.23%> (+0.60%) ⬆️
python/amici/sbml_import.py 93.81% <98.27%> (+0.25%) ⬆️
include/amici/misc.h 84.84% <100.00%> (+4.07%) ⬆️
python/amici/constants.py 100.00% <100.00%> (ø)
python/amici/import_utils.py 87.57% <100.00%> (+0.95%) ⬆️
python/amici/ode_export.py 92.90% <100.00%> (+0.51%) ⬆️
python/amici/ode_model.py 97.22% <100.00%> (+0.51%) ⬆️
... and 4 more

@FFroehlich FFroehlich marked this pull request as ready for review August 5, 2022 13:57
@FFroehlich FFroehlich requested a review from dweindl August 5, 2022 13:57
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

python/amici/ode_export.py Show resolved Hide resolved
python/amici/ode_export.py Show resolved Hide resolved
python/amici/ode_export.py Show resolved Hide resolved
python/amici/ode_export.py Outdated Show resolved Hide resolved
python/amici/ode_export.py Outdated Show resolved Hide resolved
python/amici/sbml_import.py Outdated Show resolved Hide resolved
python/amici/sbml_import.py Outdated Show resolved Hide resolved
src/model.cpp Outdated Show resolved Hide resolved
src/model.cpp Outdated Show resolved Hide resolved
include/amici/model.h Show resolved Hide resolved
src/model.cpp Outdated Show resolved Hide resolved
src/model.cpp Outdated Show resolved Hide resolved
Fabian Fröhlich and others added 4 commits August 6, 2022 09:00
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

63.3% 63.3% Coverage
0.0% 0.0% Duplication

@FFroehlich FFroehlich merged commit 3fecfd7 into develop Aug 6, 2022
@FFroehlich FFroehlich deleted the event_observables branch August 6, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants