Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate PEtab problems before attempting import #1842

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Validate PEtab problems before attempting import #1842

merged 1 commit into from
Aug 3, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Aug 3, 2022

Closes #1691

@codecov
Copy link

codecov bot commented Aug 3, 2022 •
edited
Loading

Codecov Report

Merging #1842 (82ec5a7) into develop (bb7d9d1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1842      +/-   ##
===========================================
+ Coverage    76.09%   76.11%   +0.02%     
===========================================
  Files           74       74              
  Lines        12681    12684       +3     
===========================================
+ Hits          9649     9655       +6     
+ Misses        3032     3029       -3
Flag Coverage Δ
cpp 72.75% <ø> (+0.03%) ⬆️
petab 59.39% <100.00%> (-0.05%) ⬇️
python 68.38% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/petab_import.py 64.40% <100.00%> (+0.45%) ⬆️
src/solver_cvodes.cpp 70.23% <0.00%> (+0.16%) ⬆️
src/exception.cpp 81.08% <0.00%> (+5.40%) ⬆️

@dweindl dweindl requested a review from FFroehlich August 3, 2022 09:17
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

FFroehlich
FFroehlich approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 2cb7b4e into develop Aug 3, 2022
@dweindl dweindl deleted the feature_1691 branch August 3, 2022 13:03
@dweindl dweindl linked an issue Aug 3, 2022 that may be closed by this pull request
Lint petab models #1691
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFroehlich FFroehlich FFroehlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint petab models
2 participants
@dweindl @FFroehlich