Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create_parameter_mapping kwarg forwarding #1820

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 5, 2022

Allow passing PEtab parameter mapping options through create_parameter_mapping.

Allow passing PEtab parameter mapping options through create_parameter_mapping.
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #1820 (ba689fe) into develop (8019ccc) will increase coverage by 0.73%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1820      +/-   ##
===========================================
+ Coverage    64.55%   65.29%   +0.73%     
===========================================
  Files           30       30              
  Lines         4345     4348       +3     
===========================================
+ Hits          2805     2839      +34     
+ Misses        1540     1509      -31     
Flag Coverage Δ
petab 59.54% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/petab_objective.py 93.50% <75.00%> (-0.41%) ⬇️
python/amici/sbml_import.py 91.97% <0.00%> (+0.58%) ⬆️
python/amici/ode_export.py 90.68% <0.00%> (+3.38%) ⬆️

@dweindl dweindl requested a review from dilpath July 5, 2022 13:20
python/amici/petab_objective.py Show resolved Hide resolved
@dweindl dweindl merged commit 19a18b1 into develop Jul 6, 2022
@dweindl dweindl deleted the petab_par_map_args branch July 6, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants