Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise in simulate_petab with scaled_parameters=True problem_parameters=None #1819

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 5, 2022

This case was not handled correctly. Just raise for now.

…s=None

This case was not handled correctly. Just raise for now.
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #1819 (0e7916c) into develop (6daf2d4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1819   +/-   ##
========================================
  Coverage    65.25%   65.25%           
========================================
  Files           30       30           
  Lines         4337     4337           
========================================
  Hits          2830     2830           
  Misses        1507     1507           
Flag Coverage Δ
petab 59.48% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/petab_objective.py 93.90% <100.00%> (ø)

@dweindl dweindl requested a review from dilpath July 5, 2022 11:57
@dweindl dweindl merged commit 61597f2 into develop Jul 5, 2022
@dweindl dweindl deleted the simulate_petab_nyi branch July 5, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants