Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of SBML models given as pathlib.Path in petab_import.imp… #1808

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jun 21, 2022

…ort_model_sbml

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1808 (c88ed40) into develop (c56e190) will increase coverage by 0.03%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1808      +/-   ##
===========================================
+ Coverage    76.10%   76.13%   +0.03%     
===========================================
  Files           74       74              
  Lines        12645    12647       +2     
===========================================
+ Hits          9623     9629       +6     
+ Misses        3022     3018       -4     
Flag Coverage Δ
cpp 72.80% <ø> (+0.06%) ⬆️
petab 59.48% <60.00%> (-0.01%) ⬇️
python 68.39% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/petab_import.py 63.71% <60.00%> (-0.12%) ⬇️
src/solver_cvodes.cpp 70.18% <0.00%> (+0.16%) ⬆️
src/sundials_matrix_wrapper.cpp 80.65% <0.00%> (+0.40%) ⬆️
src/exception.cpp 81.08% <0.00%> (+5.40%) ⬆️

@dweindl dweindl requested a review from FFroehlich June 21, 2022 12:47
@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl merged commit e835f94 into develop Jun 22, 2022
@dweindl dweindl deleted the fix_path_petab branch June 22, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants