Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More informative warning messages for NaNs/Infs #1798

Merged
merged 5 commits into from
May 23, 2022
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented May 19, 2022

Complements #1640

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1798 (9aeb0c0) into develop (5f5e260) will decrease coverage by 1.20%.
The diff coverage is 20.53%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1798      +/-   ##
===========================================
- Coverage    77.66%   76.45%   -1.21%     
===========================================
  Files           74       74              
  Lines        12610    12667      +57     
===========================================
- Hits          9793     9684     -109     
- Misses        2817     2983     +166     
Flag Coverage Δ
cpp 72.74% <20.53%> (-0.30%) ⬇️
petab 60.59% <ø> (ø)
python 68.19% <ø> (-2.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/amici/amici.h 100.00% <ø> (ø)
include/amici/model.h 56.00% <ø> (ø)
src/amici.cpp 70.45% <ø> (-2.09%) ⬇️
src/model.cpp 76.82% <19.09%> (-2.12%) ⬇️
src/solver_idas.cpp 37.70% <100.00%> (+0.10%) ⬆️
python/amici/conserved_quantities_demartino.py 65.55% <0.00%> (-24.66%) ⬇️
src/symbolic_functions.cpp 74.54% <0.00%> (-0.61%) ⬇️
src/sundials_matrix_wrapper.cpp 80.65% <0.00%> (+0.40%) ⬆️
src/spline.cpp 72.04% <0.00%> (+6.45%) ⬆️

@dweindl dweindl requested a review from FFroehlich May 20, 2022 15:41
@sonarcloud
Copy link

sonarcloud bot commented May 21, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl merged commit 3d0972f into develop May 23, 2022
@dweindl dweindl deleted the improve_infnan_msgs branch May 23, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants