Avoid error if no measurements in PEtab problem; fix type handling in PEtab parameter mapping #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1783 +/- ##
===========================================
+ Coverage 78.07% 78.08% +0.01%
===========================================
Files 74 74
Lines 12151 12154 +3
===========================================
+ Hits 9487 9491 +4
+ Misses 2664 2663 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dweindl
approved these changes
Apr 21, 2022
python/amici/petab_objective.py
Outdated
Comment on lines
156
to
159
| if not sim_cond.empty: | ||
| for i, rdata in enumerate(rdatas): | ||
| logger.debug(f"Condition: {sim_cond.iloc[i, :].values}, status: " | ||
| f"{rdata['status']}, llh: {rdata['llh']}") |
There was a problem hiding this comment.
Might be confusing to look at the log and not seeing any output for the respective condition? Maybe just replace {sim_cond.iloc[i, :].values} by N/A if unavailable?
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No measurements can occur if simulating a timecourse as a series of PEtab problems, where each PEtab problem has a subset of the original measurements table, and some timecourse period happens to have no measurements during it.
iterrowsfails ifsimulation_conditionsis passed as a dictionary.AMICI/python/amici/petab_objective.py
Line 281 in da34367