Remove long deprecated sbml2amici arguments modelName and constantParameters #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1774 +/- ##
===========================================
+ Coverage 73.59% 73.61% +0.01%
===========================================
Files 71 71
Lines 12055 12043 -12
===========================================
- Hits 8872 8865 -7
+ Misses 3183 3178 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
reviewed
Apr 8, 2022
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's safe to remove them...
(+ removes duplicated test
python/tests/test_misc.py::test_sbml2amici_no_observablesalso present inpython/tests/test_sbml_import.py)