Fix get_model_settings for initial states + sensitivities #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial states and initial state sensitivities should only be included if custom values have been set. Otherwise, `set_model_settings(model, get_model_settings(model))` will permanently set the given values, preventing evaluation of `Model::fx0` / `Model::fsx0`. Fixes ICB-DCM/pyPESTO#837
Codecov Report
@@ Coverage Diff @@
## develop #1751 +/- ##
===========================================
+ Coverage 77.76% 77.77% +0.01%
===========================================
Files 74 74
Lines 12012 12018 +6
===========================================
+ Hits 9341 9347 +6
Misses 2671 2671
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Mar 30, 2022
…ies in case of parameter scaling
Yes. Helped to discover another 2 old issues and 1 newly introduced issue... |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues in
amici.{get,set}_model_settingsInitial states and initial state sensitivities should only be included if custom values have been set. Otherwise,
set_model_settings(model, get_model_settings(model))will permanently set the given values, preventing evaluation ofModel::fx0/Model::fsx0.Fixes
MultiProcessEngineresults in incorrect ensemble prediction trajectories in the sampling diagnostics notebook ICB-DCM/pyPESTO#837If a model had custom initial state sensitivities set, those would not have been set correctly by
set_model_settings(model, get_model_settings(model)), becausesetParameter{List,Scale}was called aftersetInitialStateSensitivitiesand cleared initial state sensitivities. (Even if they would have been set, they would have been wrong in case of scaled parameters, due to usingsetInitialStateSensitivitiesinstead ofsetUnscaledInitialStateSensitivities).