Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speedup edata construction from petab problems #1746

Merged
merged 4 commits into from
Mar 26, 2022

Conversation

FFroehlich
Copy link
Member

No description provided.

@FFroehlich
Copy link
Member Author

tested with 20k conditions.

Not sure, might be better to rather implement this as part libpetab API.

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #1746 (d84bae5) into develop (82c5d22) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1746      +/-   ##
===========================================
+ Coverage    77.84%   77.86%   +0.01%     
===========================================
  Files           73       73              
  Lines        11422    11428       +6     
===========================================
+ Hits          8892     8898       +6     
  Misses        2530     2530              
Flag Coverage Δ
cpp 74.75% <ø> (ø)
petab 62.56% <100.00%> (+0.05%) ⬆️
python 68.09% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/petab_objective.py 93.47% <100.00%> (+0.21%) ⬆️

@sonarcloud
Copy link

sonarcloud bot commented Mar 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Agreed, could also be included in the PEtab library, but fine for now.

@FFroehlich FFroehlich merged commit db0f323 into develop Mar 26, 2022
@FFroehlich FFroehlich deleted the speedup_petab_import branch March 26, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants