Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReturnData::cpu_time_total to track total time spent in runAmiciS… #1743

Merged
merged 3 commits into from
Mar 25, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 25, 2022

…imulation

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #1743 (b5ff1bf) into develop (f60957b) will increase coverage by 9.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1743      +/-   ##
===========================================
+ Coverage    68.58%   78.26%   +9.67%     
===========================================
  Files           29       73      +44     
  Lines         4132    11972    +7840     
===========================================
+ Hits          2834     9370    +6536     
- Misses        1298     2602    +1304     
Flag Coverage Δ
cpp 74.78% <100.00%> (?)
petab 62.51% <ø> (-0.01%) ⬇️
python 68.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/amici/rdata.h 94.44% <ø> (ø)
python/amici/numpy.py 82.60% <ø> (+17.39%) ⬆️
src/amici.cpp 68.70% <100.00%> (ø)
src/hdf5.cpp 90.70% <100.00%> (ø)
src/forwardproblem.cpp 90.64% <0.00%> (ø)
src/abstract_model.cpp 4.06% <0.00%> (ø)
src/steadystateproblem.cpp 83.97% <0.00%> (ø)
include/amici/vector.h 77.27% <0.00%> (ø)
include/amici/backwardproblem.h 100.00% <0.00%> (ø)
src/model_dae.cpp 47.51% <0.00%> (ø)
... and 53 more

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Mar 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl merged commit 3683d3e into develop Mar 25, 2022
@dweindl dweindl deleted the feature_total_time branch March 25, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants