-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model import: parallelize computation of derivatives #1740
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1740 +/- ##
===========================================
+ Coverage 68.58% 77.86% +9.28%
===========================================
Files 29 73 +44
Lines 4132 11372 +7240
===========================================
+ Hits 2834 8855 +6021
- Misses 1298 2517 +1219
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Tested with https://github.com/Benchmarking-Initiative/Benchmark-Models-PEtab/tree/master/Benchmark-Models/Chen_MSB2009 on 8 core CPU, model import without compilation:
|
Tested with https://github.com/ICB-DCM/CS_Signalling_ERBB_RAS_AKT/tree/master/FroehlichKes2018/PEtab:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 neat !
f43975f
to
09085b5
Compare
SonarCloud Quality Gate failed. |
Allows to compute derivatives in parallel (using
multiprocessing
). Disabled by default. Enable by setting environment variableAMICI_IMPORT_NPROCS
to the number of processes to use. For smaller models, the multiprocessing overhead dominates, therefore, this is only advisable to use for larger models (import time of ⪆ 5min).Closes #1739