Fix Model::setStateIsNonNegative #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a logic error when handling all-false input for models with conservation laws. And adds at test.
FFroehlich
approved these changes
Mar 18, 2022
Co-authored-by: Fabian Fröhlich <fabian_froehlich@hms.harvard.edu>
Codecov Report
@@ Coverage Diff @@
## develop #1736 +/- ##
===========================================
+ Coverage 77.75% 77.84% +0.09%
===========================================
Files 73 73
Lines 11392 11395 +3
===========================================
+ Hits 8858 8871 +13
+ Misses 2534 2524 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a logic error when handling all-false input for models with conservation laws.
And adds at test.