harmonize convergence checks #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plakrisenko
reviewed
Mar 16, 2022
Codecov Report
@@ Coverage Diff @@
## develop #1731 +/- ##
===========================================
- Coverage 77.78% 77.72% -0.06%
===========================================
Files 73 73
Lines 11375 11373 -2
===========================================
- Hits 8848 8840 -8
- Misses 2527 2533 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
plakrisenko
reviewed
Mar 16, 2022
plakrisenko
approved these changes
Mar 16, 2022
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the same routines for newton and steadystate, newton still doesn't check sensitivity convergence