Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include header files in CMake targets #1639

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Include header files in CMake targets #1639

merged 2 commits into from
Jan 14, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 14, 2022

for improved IDE integration

for improved IDE integration
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #1639 (bb59b13) into develop (09a287e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1639   +/-   ##
========================================
  Coverage    78.81%   78.81%           
========================================
  Files           69       69           
  Lines        10717    10717           
========================================
  Hits          8447     8447           
  Misses        2270     2270           
Flag Coverage Δ
cpp 75.34% <ø> (ø)
petab 66.68% <ø> (ø)
python 68.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sonarcloud
Copy link

sonarcloud bot commented Jan 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 very helpful

@dweindl dweindl merged commit 8dea198 into develop Jan 14, 2022
@dweindl dweindl deleted the headers_cmake branch January 14, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants