Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to provide state IDs/names for x_solver #1638

Merged
merged 3 commits into from
Jan 13, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 13, 2022

Closes #1549

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #1638 (c695fc9) into develop (dd12502) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1638      +/-   ##
===========================================
- Coverage    78.90%   78.81%   -0.09%     
===========================================
  Files           69       69              
  Lines        10713    10717       +4     
===========================================
- Hits          8453     8447       -6     
- Misses        2260     2270      +10     
Flag Coverage Δ
cpp 75.34% <0.00%> (-0.13%) ⬇️
petab 66.68% <ø> (ø)
python 68.23% <ø> (ø)
sbmlsuite 87.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/amici/model.h 60.86% <ø> (ø)
python/amici/ode_export.py 93.60% <ø> (ø)
src/model.cpp 84.44% <0.00%> (-0.30%) ⬇️
src/spline.cpp 65.26% <0.00%> (-6.32%) ⬇️

@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
36.6% 36.6% Duplication

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 09a287e into develop Jan 13, 2022
@dweindl dweindl deleted the feature_1549_solver_state_ids branch January 13, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants