Allowing all integer parameter vector. #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannikschaelte
approved these changes
Jan 11, 2022
Codecov Report
@@ Coverage Diff @@
## develop #1634 +/- ##
========================================
Coverage 78.91% 78.91%
========================================
Files 69 69
Lines 10711 10711
========================================
Hits 8453 8453
Misses 2258 2258
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Jan 11, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluating an objective function with an all integer parameter vector throws the following error:
TypeError: in method 'SimulationParameters_parameters_set', argument 2 of type 'std::vector< amici::realtype,std::allocator< amici::realtype > > const &'This PR mitigates the requirement for manual creation of a float vector of parameters.