Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong array size in warnings #1624

Merged
merged 3 commits into from
Dec 20, 2021
Merged

Fix wrong array size in warnings #1624

merged 3 commits into from
Dec 20, 2021

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 16, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #1624 (f83f5c8) into develop (a915cc2) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1624      +/-   ##
===========================================
+ Coverage    78.91%   78.93%   +0.02%     
===========================================
  Files           69       69              
  Lines        10713    10711       -2     
===========================================
+ Hits          8454     8455       +1     
+ Misses        2259     2256       -3     
Flag Coverage Δ
cpp 75.51% <ø> (+0.03%) ⬆️
petab 66.72% <ø> (ø)
python 68.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/amici.cpp 73.43% <ø> (-0.41%) ⬇️
src/solver_cvodes.cpp 71.29% <0.00%> (+0.18%) ⬆️
src/exception.cpp 80.64% <0.00%> (+6.45%) ⬆️

@FFroehlich
Copy link
Member

But indices can't be bigger than size()-1.

@dweindl
Copy link
Member Author

dweindl commented Dec 16, 2021

But indices can't be bigger than size()-1.

"NaN value at index 0/0" looks pretty unintuitive to me... Can we then just drop the size?

@FFroehlich
Copy link
Member

FFroehlich commented Dec 17, 2021

But indices can't be bigger than size()-1.

"NaN value at index 0/0" looks pretty unintuitive to me... Can we then just drop the size?

sounds reasonable, {NaN,Inf} value for %s[%i]?

@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2021

Please retry analysis of this Pull-Request directly on SonarCloud.

@dweindl dweindl merged commit fb5a35d into develop Dec 20, 2021
@dweindl dweindl deleted the fix_msg branch December 20, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants