Remove assert_fun argument from gradient checking, improve output #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking change: previously reuired argument `assert_fun` is removed from amici.gradient_check.* `assert_fun` was probably always used to pass `assert`, and stood in the way of providing proper error messages and meaningful stack traces.
Codecov Report
@@ Coverage Diff @@
## develop #1609 +/- ##
========================================
Coverage 78.76% 78.76%
========================================
Files 67 67
Lines 10683 10683
========================================
Hits 8414 8414
Misses 2269 2269
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Fabian Fröhlich <fabian_froehlich@hms.harvard.edu>
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change:
assert_funis removed from amici.gradient_check.*check_resultandcheck_closeare now private (but were anyways not very useful by themselves)assert_funwas probably always used to passassert, and stood in the way of providing proper error messages and meaningful stack traces.