Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require sympy>=1.9,pysb>=1.13.1 / update Heaviside #1599

Merged
merged 9 commits into from
Dec 1, 2021
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 30, 2021

Require sympy>=1.9, and pysb>=1.13.1 to be compatible with the newer sympy.

Adapt to changes in sympy's Heaviside signature

This reverts commit ecffa08.

The issue has been resolved in pysb 1.13.1.
@FFroehlich
Copy link
Member

👍

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #1599 (8013311) into develop (4be0041) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1599      +/-   ##
===========================================
- Coverage    78.87%   78.80%   -0.08%     
===========================================
  Files           67       67              
  Lines        10683    10685       +2     
===========================================
- Hits          8426     8420       -6     
- Misses        2257     2265       +8     
Flag Coverage Δ
cpp 75.38% <100.00%> (-0.11%) ⬇️
petab 66.86% <0.00%> (-0.06%) ⬇️
python 68.04% <100.00%> (ø)
sbmlsuite 87.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/ode_export.py 92.87% <100.00%> (ø)
src/symbolic_functions.cpp 75.15% <100.00%> (+0.30%) ⬆️
src/spline.cpp 65.26% <0.00%> (-6.32%) ⬇️
src/sundials_matrix_wrapper.cpp 81.88% <0.00%> (-0.46%) ⬇️

@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl changed the title Revert "Require sympy<1.9" Require sympy>=1.9,pysb>=1.13.1 / update Heaviside Dec 1, 2021
@dweindl dweindl merged commit c466570 into develop Dec 1, 2021
@dweindl dweindl deleted the unpin_pysb branch December 1, 2021 10:21
dilpath added a commit that referenced this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants