Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plot labels #1598

Merged
merged 8 commits into from
Nov 30, 2021
Merged

Fix plot labels #1598

merged 8 commits into from
Nov 30, 2021

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 30, 2021

  • Remove units
  • Fix formatting
  • Fix some notebook typos

@dweindl
Fix plot labels
a522a50 
* Remove units
* Fix formatting
* Fix some notebook typos
@dweindl
--amend
1795a63
@codecov
Copy link

codecov bot commented Nov 30, 2021 •
edited
Loading

Codecov Report

Merging #1598 (e7a2157) into develop (90ed9cd) will decrease coverage by 4.38%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1598      +/-   ##
===========================================
- Coverage    78.85%   74.47%   -4.39%     
===========================================
  Files           67       23      -44     
  Lines        10683     3510    -7173     
===========================================
- Hits          8424     2614    -5810     
+ Misses        2259      896    -1363
Flag Coverage Δ
cpp ?
petab 66.92% <0.00%> (ø)
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/amici/plotting.py 0.00% <0.00%> (ø)
python/amici/pandas.py 10.96% <0.00%> (-87.10%) ⬇️
python/amici/import_utils.py 47.32% <0.00%> (-39.70%) ⬇️
python/amici/pysb_import.py 57.03% <0.00%> (-36.83%) ⬇️
python/amici/numpy.py 65.67% <0.00%> (-16.42%) ⬇️
python/amici/__init__.py 76.08% <0.00%> (-16.31%) ⬇️
python/amici/setuptools.py 50.00% <0.00%> (-7.70%) ⬇️
python/amici/parameter_mapping.py 69.56% <0.00%> (-6.09%) ⬇️
python/amici/gradient_check.py 82.60% <0.00%> (-5.44%) ⬇️
python/amici/ode_export.py 87.97% <0.00%> (-4.90%) ⬇️
... and 46 more

@dweindl dweindl requested a review from dilpath November 30, 2021 14:44
dilpath
dilpath approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can re-run the notebooks to show the updated plots.

python/examples/example_steadystate/ExampleSteadystate.ipynb Outdated Show resolved Hide resolved
dweindl and others added 2 commits November 30, 2021 16:28
@dweindl @dilpath
Update python/examples/example_steadystate/ExampleSteadystate.ipynb
b83190c 
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
@dweindl
rerun notebook
f37f8ae
dilpath
dilpath reviewed Nov 30, 2021
View reviewed changes
python/amici/plotting.py Outdated Show resolved Hide resolved
dweindl and others added 3 commits November 30, 2021 16:36
@dweindl @dilpath
Update python/amici/plotting.py
82a4e16 
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
@dweindl
rerun
02aa2b1
@dweindl
..
e7a2157
@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2021

Please retry analysis of this Pull-Request directly on SonarCloud.

@dweindl dweindl merged commit 4be0041 into develop Nov 30, 2021
@dweindl dweindl deleted the fix_plotting branch November 30, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilpath dilpath dilpath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dweindl @dilpath