Codify some of the implicitly assumed conventions #439
Conversation
|
There are some other tests that could use this, the legacy ones (I guess you don't care about those), but also |
|
Fixed the usage in the non-legacy tests. for the legacy tests it doesn't really make sense, I think. As discussed during the meeting today we will merge this now to unblock a few things that depend on this and to bring the nightlies (of Key4hep) back to a working state. |
tmadlener
force-pushed
the
category-conventions
branch
from
068619e
to
60d1065
Compare
| * either commonly used category names, or category names that form a | ||
| * convention. | ||
| */ | ||
| namespace Category { |
There was a problem hiding this comment.
Mainly because this way I can directly use it in everything that expects a string, rather than having to have some conversion from an enum value to a string. Additionally, I didn't find a use case yet where an actual enum was necessary, so I wen't with the minimal solution here.
BEGINRELEASENOTES
FrameCategories.hheader that puts a few of the conventions and otherwise hardcoded strings into variables / functions.ENDRELEASENOTES
Should make it easier to keep the various implicit decisions that were made consistent with each other and avoid situations with too many magic values. See also discussion in AIDASoft/DD4hep#1140