Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing slo-reporter and integration tests in prod #772

Conversation

Gregory-Pereira
Copy link
Contributor

created integration test and slo reporter argocd applications for balrog.
updated smaug slo-reporter application to run in thoth-frontend-stage namespace.

/cc @harshad16
/cc @mayaCostantini

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 22, 2022
@Gregory-Pereira
Copy link
Contributor Author

Gregory-Pereira commented Mar 22, 2022

pre-commit is failing due to thoth-station/thoth-application Issue 2111. Opening a PR for this. Should retest after #773 gets merged.

@Gregory-Pereira
Copy link
Contributor Author

/hold

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2022
@harshad16
Copy link
Member

/retest

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @Gregory-Pereira
just one change required:

@anishasthana
Copy link
Contributor

@Gregory-Pereira bump

@Gregory-Pereira
Copy link
Contributor Author

@Gregory-Pereira bump

Thanks for the bump Anish, it got lost in my notifications, I will fix this now.

created integration test and slo reporter argocd applications for balrog.
updated smaug slo-reporter application to run in thoth-frontend-stage ns.
@Gregory-Pereira Gregory-Pereira force-pushed the fixing-slo-reporter-and-integration-tests-prod branch from fa495ac to b900baa Compare March 31, 2022 16:39
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes
/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2022
@harshad16
Copy link
Member

/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2022
@sesheta
Copy link
Contributor

sesheta commented Mar 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2022
@sesheta sesheta merged commit 6205bd3 into AICoE:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants