-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing slo-reporter and integration tests in prod #772
fixing slo-reporter and integration tests in prod #772
Conversation
pre-commit is failing due to thoth-station/thoth-application Issue 2111. Opening a PR for this. Should retest after #773 gets merged. |
/hold |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work @Gregory-Pereira
just one change required:
manifests/overlays/prod/applications/thoth-station/prod/prod-thoth-integration-tests-aws.yaml
Outdated
Show resolved
Hide resolved
@Gregory-Pereira bump |
Thanks for the bump Anish, it got lost in my notifications, I will fix this now. |
created integration test and slo reporter argocd applications for balrog. updated smaug slo-reporter application to run in thoth-frontend-stage ns.
fa495ac
to
b900baa
Compare
manifests/overlays/prod/applications/thoth-station/prod/prod-slo-reporter-aws.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the changes
/lgtm
/approve
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
created integration test and slo reporter argocd applications for balrog.
updated smaug slo-reporter application to run in thoth-frontend-stage namespace.
/cc @harshad16
/cc @mayaCostantini