Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vertex support #182

Merged
merged 21 commits into from
Aug 22, 2024
Merged

feat: add vertex support #182

merged 21 commits into from
Aug 22, 2024

Conversation

miri-bar
Copy link
Contributor

@miri-bar miri-bar commented Jul 9, 2024

No description provided.

@miri-bar miri-bar requested a review from a team July 9, 2024 14:15
Copy link
Contributor

@pazshalev pazshalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Few comments

tests/integration_tests/skip_helpers.py Show resolved Hide resolved
tests/integration_tests/clients/test_vertex.py Outdated Show resolved Hide resolved
tests/unittests/clients/vertex/test_chat_completions.py Outdated Show resolved Hide resolved
tests/unittests/test_gcp_authorization.py Outdated Show resolved Hide resolved
ai21/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Josephasafg Josephasafg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! 🚀

@github-actions github-actions bot added lgtm Looks Good to Me size:xxl and removed size:xxl labels Jul 15, 2024
@miri-bar miri-bar merged commit 0c7a32d into main Aug 22, 2024
24 checks passed
@miri-bar miri-bar deleted the add_vertex_support branch August 22, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation Update lgtm Looks Good to Me size:xxl vertex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants