Ns rse/fix tests test plottingfuncs #908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com/AFM-SPM/TopoStats into maxgamill-sheffield/800-btr_nodestats2
…sheffield/800-btr-ordered-tracing
….com/AFM-SPM/TopoStats into maxgamill-sheffield/800-btr-splining
… and .topostats outputs
…TopoStats into maxgamill-sheffield/RIs
Co-authored-by: llwiggins <91545985+llwiggins@users.noreply.github.com>
…ning Add final btr splining changes
Adding RI code to handle and break odd crossings
Fixes a bunch of linting errors, some notes left in place for tasks to be completed (e.g. see #899).
Closes #899 Also updates `test_process_stages()` although this includes disabling a one set of parameters for the time being until I work out what is now happening.
Fixes a bunch of linting errors, some notes left in place for tasks to be completed (e.g. see #899).
Within `processing.run_splining()`... + `grainstats_additions_image` > `splining_stats` + `grainstats_additions_df` > `_splining_stats` (prefix of `_` denotes private object) Within `topostats.tracing.splining_image()` + `grainstats_additions_df` > `splining_stats_df`
+ `blu` > `blue` in `test_mask_dilation()` and `test_mask_cmap()` to reflect change in `topostats/theme.py` + deduplicate `# pylint: disable` from `topostats/plottingfuncs.py`
ns-rse
requested review from
SylviaWhittle,
MaxGamill-Sheffield and
llwiggins
|
D'oh forgot to change the target branch! 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of a series of PRs that will restore the tests that are failing from
tests/test_plottingfuncs.py.I'm looking to adopt the Stacked PRs workflow so will be making changes on top of these.