Filter out non-standard channels from channelInfo API
#2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala
…e.scala Co-authored-by: Pierre-Marie Padiou <pm47@users.noreply.github.com>
# Conflicts: # eclair-core/src/test/scala/fr/acinq/eclair/integration/ChannelIntegrationSpec.scala # eclair-core/src/test/scala/fr/acinq/eclair/integration/PaymentIntegrationSpec.scala # eclair-core/src/test/scala/fr/acinq/eclair/payment/PaymentInitiatorSpec.scala # eclair-core/src/test/scala/fr/acinq/eclair/payment/PaymentLifecycleSpec.scala # eclair-node/src/main/scala/fr/acinq/eclair/api/handlers/Invoice.scala
# Conflicts: # eclair-core/src/test/scala/fr/acinq/eclair/payment/PaymentInitiatorSpec.scala # eclair-core/src/test/scala/fr/acinq/eclair/payment/PaymentLifecycleSpec.scala
Codecov Report
@@ Coverage Diff @@
## master #2107 +/- ##
==========================================
- Coverage 87.73% 87.63% -0.11%
==========================================
Files 159 165 +6
Lines 12455 12758 +303
Branches 522 535 +13
==========================================
+ Hits 10927 11180 +253
- Misses 1528 1578 +50
|
t-bast
reviewed
Dec 15, 2021
|
Sigh, looks like I've done something wrong again with squashing, maybe we can do without it? |
Sure, no worries. It's really worth a bit of time to learn to master git, it's not that hard and really helps productivity, I can only highly recommend it! |
t-bast
reviewed
Dec 15, 2021
eclair-core/src/test/scala/fr/acinq/eclair/EclairImplSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/EclairImplSpec.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Bastien Teinturier <31281497+t-bast@users.noreply.github.com>
t-bast
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible for a non-standard channel to reply with
CommandFailurewhich in turn will be filtered out inchannelsInfomethod.The reason is that currently hosted channels have to return something to make the whole API call succeed and whatever they return would break external tools which only expect standard channel formats.