Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode warning messages #1854

Merged
merged 2 commits into from
Jul 1, 2021
Merged

Decode warning messages #1854

merged 2 commits into from
Jul 1, 2021

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Jun 30, 2021

Add support for logging warning messages as introduced in lightning/bolts#834
Support for sending warning messages instead of current errors will be added in a later PR.
Note that c-lightning already sends these messages, so it will be useful to have them correctly logged.
Even if the spec PR is eventually changed, this will not introduce backwards-compatibility issues so IMO it's worth merging on master now.

Add support for logging warning messages as introduced in
lightning/bolts#834

Support for sending warning messages instead of current errors will be
added in a later PR.
@t-bast t-bast requested a review from pm47 June 30, 2021 14:42
@codecov-commenter
Copy link

Codecov Report

Merging #1854 (19acba9) into master (85ed433) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1854      +/-   ##
==========================================
- Coverage   88.94%   88.94%   -0.01%     
==========================================
  Files         150      150              
  Lines       11239    11248       +9     
  Branches      447      449       +2     
==========================================
+ Hits         9997    10004       +7     
- Misses       1242     1244       +2     
Impacted Files Coverage Δ
...-core/src/main/scala/fr/acinq/eclair/io/Peer.scala 89.58% <0.00%> (-0.95%) ⬇️
...q/eclair/wire/protocol/LightningMessageTypes.scala 84.61% <75.00%> (-1.75%) ⬇️
.../eclair/wire/protocol/LightningMessageCodecs.scala 100.00% <100.00%> (ø)
...main/scala/fr/acinq/eclair/io/PeerConnection.scala 84.68% <0.00%> (-0.43%) ⬇️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 86.27% <0.00%> (+0.08%) ⬆️
...cinq/eclair/channel/publish/MempoolTxMonitor.scala 81.81% <0.00%> (+1.29%) ⬆️

@t-bast t-bast merged commit f52c3dd into master Jul 1, 2021
@t-bast t-bast deleted the warning-messages branch July 1, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants