Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential race condition in node-relay #1716

Merged
merged 3 commits into from
Mar 8, 2021

Commits on Mar 4, 2021

  1. Fix potential race condition in node-relay

    We previously relied on `context.child` to check whether we already had a
    relay handler for a given payment_hash.
    
    Unfortunately this could return an actor that is currently stopping itself.
    When that happens our relay command can end up in the dead letters and the
    payment will not be relayed, nor be failed upstream.
    
    We fix that by maintaining the list of current relay handlers in the
    NodeRelayer and removing them from the list before stopping them.
    This is similar to what's done in the MultiPartPaymentFSM.
    t-bast committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    fafd66f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5253c30 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. Configuration menu
    Copy the full SHA
    0ddbc2b View commit details
    Browse the repository at this point in the history