Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Sockethub IRC connect flow, show connect errors #274

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

raucao
Copy link
Member

@raucao raucao commented Feb 6, 2022

Implements and relies on sockethub/sockethub#671

closes #194

@raucao
Copy link
Member Author

raucao commented Feb 6, 2022

@silverbucket For some reason, the yarn build is failing with Sockethub master on Travis CI now:

The command "yarn run build" failed and exited with 127 during .

https://app.travis-ci.com/github/67P/hyperchannel/builds/245985117

@raucao
Copy link
Member Author

raucao commented Feb 7, 2022

I have found the CI build problem. For some reason, the standard yarn install in sockethub's root package.json does not run the lerna bootstrap/install anymore. I changed it to the new npm script, but I think this is less clean and intuitive than a standard yarn install && yarn start.

@raucao raucao changed the title Use new separate IRC connect, show connect errors Use new Sockethub IRC connect flow, show connect errors Feb 7, 2022
@silverbucket
Copy link
Member

silverbucket commented Feb 7, 2022

@raucao yeah, unfortunately this is a limitation of lerna when there is a package.json in the root of the repository (in additon to each packages package.json). I created an issue here explaining it lerna/lerna#3070, in the meantime we're going to have to use yarn run deps as the one-step command to install all dependencies.

Copy link
Member

@silverbucket silverbucket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raucao raucao merged commit 69a216d into master Feb 7, 2022
@raucao raucao deleted the feature/irc_connect branch February 7, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test server config/connection before creating/saving a new account
2 participants